Code

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14148 closed (fixed)

Django assumes that module.__file__ is an absolute path

Reported by: Alex Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

This isn't always the case, on both PyPy and CPython it seems to happen "randomly" (aka theres a logic to it that I'm not sure of). This causes the tests to fail on PyPy reliably, I can't figure out why they don't fail on CPython, but they don't.

Attachments (1)

django-abspath.diff (772 bytes) - added by Alex 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by Alex

comment:1 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [13618]) Fixed #14148 -- Ensure the admin_script tests always use an absolute path; PyPy (and sometimes CPython) return relative paths for file. Thanks to Alex Gaynor for the report and patch.

comment:2 Changed 4 years ago by russellm

(In [13619]) [1.2.X] Fixed #14148 -- Ensure the admin_script tests always use an absolute path; PyPy (and sometimes CPython) return relative paths for file. Thanks to Alex Gaynor for the report and patch.

Backport of r13618 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.