Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#14148 closed (fixed)

Django assumes that module.__file__ is an absolute path

Reported by: Alex Gaynor Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This isn't always the case, on both PyPy and CPython it seems to happen "randomly" (aka theres a logic to it that I'm not sure of). This causes the tests to fail on PyPy reliably, I can't figure out why they don't fail on CPython, but they don't.

Attachments (1)

django-abspath.diff (772 bytes) - added by Alex Gaynor 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Alex Gaynor

Attachment: django-abspath.diff added

comment:1 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [13618]) Fixed #14148 -- Ensure the admin_script tests always use an absolute path; PyPy (and sometimes CPython) return relative paths for file. Thanks to Alex Gaynor for the report and patch.

comment:2 Changed 6 years ago by Russell Keith-Magee

(In [13619]) [1.2.X] Fixed #14148 -- Ensure the admin_script tests always use an absolute path; PyPy (and sometimes CPython) return relative paths for file. Thanks to Alex Gaynor for the report and patch.

Backport of r13618 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top