Code

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#14132 closed (fixed)

Feedgenerator doesn't support dates before 1900

Reported by: mlissner Owned by: jezdez
Component: Contrib apps Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

In the aggregation framework, if a date prior to 1900 is used in the item_pubdate field, a ValueError is thrown. In my system, we use the pubdate field for the date that the document was originally written, and many of the documents we have were written in the 1700s.

In this bug, which was fixed in 2006, I think strftime was supposed to be fixed throughout the platform: http://code.djangoproject.com/ticket/1443

It would be great if it could get fixed here too.

Attachments (1)

fix14132.patch (2.0 KB) - added by mk 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by mk

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to mk
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Summary changed from Feedparser doesn't support dates before 1900 to Feedgenerator doesn't support dates before 1900
  • Triage Stage changed from Unreviewed to Accepted

This affects feedgenerator, not feedparser.

Changed 4 years ago by mk

comment:2 Changed 3 years ago by mk

  • milestone set to 1.3
  • Owner mk deleted
  • Status changed from assigned to new

Assigning to milestone 1.3, because this is a simple fix which mirrors other bugfixes in Django and has tests included.

comment:3 Changed 3 years ago by ramiro

  • Patch needs improvement set

Patch needs updating because code in the region it touches was changed in r15112.

comment:4 Changed 3 years ago by jezdez

  • Owner set to jezdez
  • Resolution set to fixed
  • Status changed from new to closed

In [15503]:

Fixed #14132 -- Fixed feedgenerator to support years < 1900. Thanks, mk.

comment:5 Changed 3 years ago by jezdez

In [15510]:

[1.2.X] Fixed #14132 -- Fixed feedgenerator to support years < 1900. Thanks, mk.

Backport from trunk (r15503).

comment:6 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.