Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14132 closed (fixed)

Feedgenerator doesn't support dates before 1900

Reported by: Mike Lissner Owned by: Jannis Leidel
Component: Contrib apps Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

In the aggregation framework, if a date prior to 1900 is used in the item_pubdate field, a ValueError is thrown. In my system, we use the pubdate field for the date that the document was originally written, and many of the documents we have were written in the 1700s.

In this bug, which was fixed in 2006, I think strftime was supposed to be fixed throughout the platform: http://code.djangoproject.com/ticket/1443

It would be great if it could get fixed here too.

Attachments (1)

fix14132.patch (2.0 KB) - added by Matthias Kestenholz 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Matthias Kestenholz

Has patch: set
Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Matthias Kestenholz
Patch needs improvement: unset
Status: newassigned
Summary: Feedparser doesn't support dates before 1900Feedgenerator doesn't support dates before 1900
Triage Stage: UnreviewedAccepted

This affects feedgenerator, not feedparser.

Changed 6 years ago by Matthias Kestenholz

Attachment: fix14132.patch added

comment:2 Changed 6 years ago by Matthias Kestenholz

milestone: 1.3
Owner: Matthias Kestenholz deleted
Status: assignednew

Assigning to milestone 1.3, because this is a simple fix which mirrors other bugfixes in Django and has tests included.

comment:3 Changed 6 years ago by Ramiro Morales

Patch needs improvement: set

Patch needs updating because code in the region it touches was changed in r15112.

comment:4 Changed 6 years ago by Jannis Leidel

Owner: set to Jannis Leidel
Resolution: fixed
Status: newclosed

In [15503]:

Fixed #14132 -- Fixed feedgenerator to support years < 1900. Thanks, mk.

comment:5 Changed 6 years ago by Jannis Leidel

In [15510]:

[1.2.X] Fixed #14132 -- Fixed feedgenerator to support years < 1900. Thanks, mk.

Backport from trunk (r15503).

comment:6 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top