Opened 6 years ago

Closed 6 years ago

#14125 closed (duplicate)

'Safe strings' are not force-escaped on development 500 page

Reported by: Elijah Rutschman Owned by: Elijah Rutschman
Component: Uncategorized Version: master
Severity: Keywords: debug.py 500 escape
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the 'Local vars' section of the debugging 500 error page, strings that have been 'marked safe' are not escaped before output, which has often resulted in HTML from my variables being inserted into the page.

While using 'mark_safe' on a string variable indicates that the string should not be escaped further, I think an exception should be made for the debugging 500 page, based on my assumption that most developers would rather see a string's value than the resultant HTML elements.

I have attached a patch that uses 'force_escape' in lieu of 'escape'.

Attachments (1)

debug.py.diff (578 bytes) - added by Elijah Rutschman 6 years ago.
Force escape 'Local vars' output on debug page

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Elijah Rutschman

Attachment: debug.py.diff added

Force escape 'Local vars' output on debug page

comment:1 Changed 6 years ago by Elijah Rutschman

Owner: changed from nobody to Elijah Rutschman
Status: newassigned

comment:2 Changed 6 years ago by VickyTuite

Needs tests: set
Triage Stage: UnreviewedAccepted

comment:3 Changed 6 years ago by VickyTuite

Triage Stage: AcceptedDesign decision needed

comment:4 Changed 6 years ago by Chris Beaven

Resolution: duplicate
Status: assignedclosed

Dupe of #7697

Note: See TracTickets for help on using tickets.
Back to Top