Code

Opened 4 years ago

Closed 4 years ago

#14086 closed (fixed)

Tests don't pass on Python 2.4 because of a try/except/finally

Reported by: PaulM Owned by: nobody
Component: contrib.sessions Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

We still can't use unified try/except/finally blocks because we support Python 2.4.

Contrib tests currently have at least one such statement, and so they fail.

http://code.djangoproject.com/browser/django/trunk/django/contrib/sessions/tests.py

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by lrekucki

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

I can't find the relevant docs right now, but AFAIK Django 1.3 (aka current trunk) will stop supporting Python 2.4 as a part of the process to support Python3 some day. I checked that tests on 1.2.X branch run without problems. Thanks for your caution!

comment:2 Changed 4 years ago by PaulM

The reason you can't find the relevant docs is because they don't seem to exist. Nothing has been publicly announced related to this matter (hence the bug report). I've raised the matter on the dev list, rather than re-opening this ticket.

comment:3 Changed 4 years ago by lrekucki

You're right. Sorry, I should have probably asked first on django-dev myself.

comment:4 Changed 4 years ago by russellm

  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Unreviewed to Design decision needed

Reopening; until such time as we make a decision to deprecate Python 2.4, this remains an issue.

comment:5 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [13579]) Fixed #14086 -- Corrected Python 2.4 syntax issue. Thanks to PaulM for the report.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.