Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#1396 closed defect (fixed)

[magic-removal][patch] Not checking for silent_variable_failure in related object lookups

Reported by: Max Battcher <me@…> Owned by: Russell Keith-Magee
Component: Template system Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As of r2384 of magic-removal: resolve_variable in django.template was not checking for silent_variable_failure in attribute lookup, which is the post-Descriptor way of getting Related Objects.

Attachments (1)

relatedobject.patch (744 bytes) - added by Max Battcher <me@…> 11 years ago.
Patch

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Max Battcher <me@…>

Attachment: relatedobject.patch added

Patch

comment:1 Changed 11 years ago by Max Battcher <me@…>

Summary: Not checking for silent_variable_failure in related object lookups[magic-removal][patch] Not checking for silent_variable_failure in related object lookups

Make it obvious what it refers to and that I attached a patch.

comment:2 Changed 11 years ago by Russell Keith-Magee

Owner: changed from Adrian Holovaty to Russell Keith-Magee

comment:3 Changed 11 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [2604]) magic-removal: Fixes #1396 -- Added exception handler (and silent_variable_failure check) for edge case in descriptor lookup.

Note: See TracTickets for help on using tickets.
Back to Top