Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13934 closed (fixed)

GeoSQLCompiler.get_default_columns() is missing local_only parameter

Reported by: Simon Law Owned by: jbronn
Component: GIS Version: 1.2
Severity: Keywords: select_related local_only get_default_columns GeoDjango GeoSQLCompiler
Cc: simon@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by jbronn)

If you try to select_related() with a GeoManager, things get pretty nasty with Django 1.2.

You get a TypeError, claiming that get_default_columns() does not support the local_only parameter.

Included is a patch that ports the functionality over.

Attachments (2)

gis-local_only.patch (1.4 KB) - added by Simon Law 6 years ago.
testapp.tar.gz (770 bytes) - added by Simon Law 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Simon Law

Attachment: gis-local_only.patch added

comment:1 Changed 6 years ago by jbronn

milestone: 1.3
Owner: changed from nobody to jbronn
Status: newassigned

comment:2 Changed 6 years ago by jbronn

Description: modified (diff)

Obviously, the code needs to be synced up. However, the existing tests for select_related aren't blowing up -- can you provide a simple example that raises the TypeError? I want to explicitly test for the condition that induces the failure to ensure it doesn't regress.

comment:3 Changed 6 years ago by Simon Law

Attached is a test app (with a test case) that breaks without my patch.

I'm not sure how to add this to django.contrib.gis, but I hope it helps.

Changed 6 years ago by Simon Law

Attachment: testapp.tar.gz added

comment:4 Changed 6 years ago by jbronn

Resolution: fixed
Status: assignedclosed

(In [13439]) Fixed #13934 -- GeoSQLCompiler.get_default_columns was missing local_only keyword argument. Thanks, Simon Law, for bug report and initial patch.

comment:5 Changed 6 years ago by jbronn

(In [13440]) [1.2.X] Fixed #13934 -- GeoSQLCompiler.get_default_columns was missing local_only keyword argument. Thanks, Simon Law, for bug report and initial patch.

Backport of r13439 from trunk.

comment:6 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top