#13934 closed (fixed)
GeoSQLCompiler.get_default_columns() is missing local_only parameter
| Reported by: | Simon Law | Owned by: | jbronn |
|---|---|---|---|
| Component: | GIS | Version: | 1.2 |
| Severity: | Keywords: | select_related local_only get_default_columns GeoDjango GeoSQLCompiler | |
| Cc: | simon@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
If you try to select_related() with a GeoManager, things get pretty nasty with Django 1.2.
You get a TypeError, claiming that get_default_columns() does not support the local_only parameter.
Included is a patch that ports the functionality over.
Attachments (2)
Change History (8)
by , 14 years ago
| Attachment: | gis-local_only.patch added |
|---|
comment:1 by , 14 years ago
| milestone: | → 1.3 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 14 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 14 years ago
Attached is a test app (with a test case) that breaks without my patch.
I'm not sure how to add this to django.contrib.gis, but I hope it helps.
by , 14 years ago
| Attachment: | testapp.tar.gz added |
|---|
comment:4 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 by , 14 years ago
Note:
See TracTickets
for help on using tickets.
Obviously, the code needs to be synced up. However, the existing tests for
select_relatedaren't blowing up -- can you provide a simple example that raises theTypeError? I want to explicitly test for the condition that induces the failure to ensure it doesn't regress.