GeometryCollections are not visible in OSMGeoAdmin

[anonymous]

Geometry collections fail to display in OSMGeoAdmin.

The bug appears in the geodjango_geom.write_wkt function:

geodjango_geom.write_wkt = function(feat){
if (geodjango_geom.is_collection){ geodjango_geom.num_geom = feat.geometry.components.length;}
  else { geodjango_geom.num_geom = 1;}
  document.getElementById('id_geom').value = geodjango_geom.get_ewkt(feat);
} 

If 'feat' is a geometry collection, it does not have a geometry property, but it is an array of type OpenLayers.Feature.Vector.

[anonymous]

Attempted attaching a patch, but it didn't happen. Here it is:

* openlayers-dist.js 2010-07-12 12:19:47.126525645 -0400
--- openlayers.js 2010-07-12 12:22:44.874936920 -0400
*
* 17,23

return {{ module }}.wkt_f.read(wkt);

}
{{ module }}.write_wkt = function(feat){

! if ({{ module }}.is_collection){ {{ module }}.num_geom = feat.geometry.components.length;}

else { {{ module }}.num_geom = 1;}
document.getElementById('{{ id }}').value = {{ module }}.get_ewkt(feat);

}

--- 17,23 ----

return {{ module }}.wkt_f.read(wkt);

}
{{ module }}.write_wkt = function(feat){

! if ({{ module }}.is_collection){ {{ module }}.num_geom = feat.length;}

else { {{ module }}.num_geom = 1;}
document.getElementById('{{ id }}').value = {{ module }}.get_ewkt(feat);

}

[anonymous]

The above patch is for django/contrib/gis/templates/gis/admin/openlayers.js

[anonymous]

Patch for real.

[patchhammer]

openlayers.patch fails to apply cleanly on to trunk

[elpaso66]

New patch for django/contrib/gis/templates/gis/admin/openlayers.js, should apply on trunk.

[Antti Kaihola]

Patch updated for the Django 1.5.1 release

[Antti Kaihola]

Patch updated for current Django trunk

[Claude Paroz]

Thanks for maintaining the patch up-to-date.
With the recent addition (Django 1.6) of GIS-specialized form fields and widgets (#5472), GeoModelAdmin/OSMGeoAdmin will become mostly obsolete, and the geometry collections issue should be solved.

I would be interested by any experience on using the new fields/widgets with any GIS project using Django 1.6 and normal ModelAdmin objects.

[Greg]

The patch does not appear to be applied in Django 1.7 and geometry collections are not rendered in geomodeladmin

[Claude Paroz]

GregUK, what about using a normal ModelAdmin (in lieu of a GeoModelAdmin)?

[Mariusz Felisiak]

GeoModelAdmin and OSMGeoAdmin are deprecated (see 4555aa0a489cb9dcf764edf12339097cdfa5ff84). Please reopen the ticket if you can confirm your issue with admin.ModelAdmin.