Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#1389 closed defect (fixed)

Bug in admin stylesheet? (magic-removal)

Reported by: russell@… Owned by: adrian
Component: contrib.admin Version: magic-removal
Severity: normal Keywords:
Cc: cmlenz@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

I'm getting some funnys with the collapsed fieldsets using the magic-removal branch. I'm not sure if it's fixed in another branch, or if magic-removal is even the right place to fix it. Anyways, here's the patch:

--- magic-removal/django/contrib/admin/media/css/global.css.orig        2006-02-23 10:49:01.000000000 +0200
+++ magic-removal/django/contrib/admin/media/css/global.css     2006-02-23 10:48:18.000000000 +0200
@@ -167,10 +167,9 @@

 /* COLLAPSED FIELDSETS */
 fieldset.collapsed * { display:none; }
-fieldset.collapsed h2, fieldset.collapsed .collapse-toggle  { display:block !important; }
+fieldset.collapsed h2, fieldset.collapsed { display:block !important; }
 fieldset.collapsed h2 { background-image:url(../img/admin/nav-bg.gif); background-position:bottom left; color:#999; }
-fieldset.collapsed .collapse-toggle { padding:3px 5px !important; background:#efefef; }
-fieldset.collapsed .collapse-toggle a { display:inline !important; }
+fieldset.collapsed .collapse-toggle { padding:3px 5px !important; background: transparent; display:inline !important;}

 /* MONOSPACE TEXTAREAS */
 fieldset.monospace textarea { font-family:"Bitstream Vera Sans Mono",Monaco,"Courier New",Courier,monospace; }

As you can see, the wrong things were being made block-level, and so the "Show" link was appearing on the line below the fieldset's title.

Patch tested in FF 1.0.x and IE 6.0

Russell

Change History (2)

comment:1 Changed 10 years ago by Christopher Lenz <cmlenz@…>

  • Cc cmlenz@… added

Seeing the same thing here, and your patch fixes the issue.

comment:2 Changed 10 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [2372]) magic-removal: Fixed #1389 -- Fixed admin CSS bug. Thanks, russell@…

Note: See TracTickets for help on using tickets.
Back to Top