Changes between Initial Version and Version 23 of Ticket #13883


Ignore:
Timestamp:
Mar 25, 2022, 10:02:50 AM (2 years ago)
Author:
Narbonne
Comment:

I don't see an update of the filter method. I suppose search should also search in the optgroup name (a bit like sort before token search). I update your patch line 45 in filter: 

const node_text = (node.group && node.group.toLowerCase() || '') + node.text.toLowerCase();

Also, maybe it could make sense to move optgroup as a block.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #13883

    • Property Component Contrib apps → django.contrib.admin
    • Property Cc minimallyuseless@… Narbonne Jignesh Kotadiya added
    • Property Keywords sprintdec2010 added
    • Property Patch needs improvement set
    • Property Triage Stage Unreviewed → Accepted
    • Property Severity → Normal
    • Property Type → Bug
    • Property Easy pickings set
    • Property UI/UX set
    • Property Version 1.2 → master
    • Property Owner nobody removed

  • Ticket #13883 – Description

    initial v23  
    1 Current implementation ignores optgroup elements in selects. Here is an example of SelectBox.js which takes optgroups in account, but uses jQuery (already used by django admin anyway).
    2 The script is not perfectly written. I can rewrite this to meet django's coding/quality standards if needed.
Back to Top