Opened 15 years ago

Last modified 6 weeks ago

#13883 assigned

SelectBox.js with grouping (optgroup elements) — at Initial Version

Reported by: SardarNL Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords: admin, SelectBox, optgroup, sprintdec2010
Cc: minimallyuseless@…, Narbonne, Jignesh Kotadiya, Michael McLarnon, Ülgen Sarıkavak Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes
Pull Requests:18934 build:success, 15568, 12867 unmerged, 12738 unmerged, 12737 unmerged

Description

Current implementation ignores optgroup elements in selects. Here is an example of SelectBox.js which takes optgroups in account, but uses jQuery (already used by django admin anyway).
The script is not perfectly written. I can rewrite this to meet django's coding/quality standards if needed.

According to the ticket's flags, the next step(s) to move this issue forward are:

  • For anyone except the patch author to review the patch using the patch review checklist and either mark the ticket as "Ready for checkin" if everything looks good, or leave comments for improvement and mark the ticket as "Patch needs improvement".

Change History (3)

by SardarNL, 15 years ago

Attachment: bad_select.png added

Current SelectBox.js screenshot

by SardarNL, 15 years ago

Attachment: good_select.png added

Better SelectBox.js screenshot. optgroups are recreated on redisplay()

by SardarNL, 15 years ago

Attachment: SelectBox.js added

Better SelectBox.js which handles optgroup, depends on jQuery

Note: See TracTickets for help on using tickets.
Back to Top