Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1387 closed defect (fixed)

some xml parsing errors in firefox

Reported by: vineet Owned by: adrian
Component: contrib.syndication Version: new-admin
Severity: major Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I've noticed a few problems with pages that won't render due to having some invalid XML. Here's a patch
fixing 2 of them:

Index: django/contrib/admin/templates/admin/change_form.html
===================================================================
--- django/contrib/admin/templates/admin/change_form.html       (revision 2368)
+++ django/contrib/admin/templates/admin/change_form.html       (working copy)
@@ -21,7 +21,7 @@
   </ul>
 {% endif %}{% endif %}
 <form {{ bound_manipulator.form_enc_attrib }} action="{{ form_url }}" method="post">{% block form_top %}{% endblock %}
-{% if is_popup %}<input type="hidden" name="_popup" value="1">{% endif %}
+{% if is_popup %}<input type="hidden" name="_popup" value="1"/>{% endif %}
 {% if bound_manipulator.save_on_top %}{% submit_row bound_manipulator %}{% endif %}
 {% if form.error_dict %}
     <p class="errornote">
Index: django/contrib/admin/templates/admin_doc/bookmarklets.html
===================================================================
--- django/contrib/admin/templates/admin_doc/bookmarklets.html  (revision 2368)
+++ django/contrib/admin/templates/admin_doc/bookmarklets.html  (working copy)
@@ -16,7 +16,7 @@
 {% endblocktrans %}
 
 <div id="content-main">
-    <h3><a href="javascript:(function(){if(typeof ActiveXObject!='undefined'){x=new ActiveXObject('Microsoft.XMLHTTP')}else if(typeof XMLHttpRequest!='undefined'){x=new XMLHttpRequest()}else{return;}x.open('HEAD',location.href,false);x.send(null);try{view=x.getResponseHeader('x-view');}catch(e){alert('No view found for this page');return;}if(view=="undefined"){alert("No view found for this page");}document.location='{{ admin_url }}doc/views/'+view+'/';})()">{% trans "Documentation for this page" %}</a></h3>
+    <h3><a href="javascript:(function(){if(typeof ActiveXObject!='undefined'){x=new ActiveXObject('Microsoft.XMLHTTP')}else if(typeof XMLHttpRequest!='undefined'){x=new XMLHttpRequest()}else{return;}x.open('HEAD',location.href,false);x.send(null);try{view=x.getResponseHeader('x-view');}catch(e){alert('No view found for this page');return;}if(view=='undefined'){alert('No view found for this page');}document.location='{{ admin_url }}doc/views/'+view+'/';})()">{% trans "Documentation for this page" %}</a></h3>
     <p>{% trans "Jumps you from any page to the documentation for the view that generates that page." %}</p>

     <h3><a href="javascript:(function(){if(typeof ActiveXObject!='undefined'){x=new ActiveXObject('Microsoft.XMLHTTP')}else if(typeof XMLHttpRequest!='undefined'){x=new XMLHttpRequest()}else{return;}x.open('GET',location.href,false);x.send(null);try{type=x.getResponseHeader('x-object-type');id=x.getResponseHeader('x-object-id');}catch(e){type='(none)';id='(none)';}d=document;b=d.body;e=d.createElement('div');e.id='xxxhhh';s=e.style;s.position='absolute';s.left='10px';s.top='10px';s.font='10px monospace';s.border='1px black solid';s.padding='4px';s.backgroundColor='#eee';e.appendChild(d.createTextNode('Type: '+type));e.appendChild(d.createElement('br'));e.appendChild(d.createTextNode('ID: '+id));e.appendChild(d.createElement('br'));l=d.createElement('a');l.href='#';l.onclick=function(){b.removeChild(e);};l.appendChild(d.createTextNode('[close]'));l.style.textDecoration='none';e.appendChild(l);b.appendChild(e);})();">{% trans "Show object ID" %}</a></h3>

Change History (4)

comment:1 Changed 9 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [2371]) Fixed #1387 -- Fixed some XHTML errors in admin templates. Thanks, vineet

comment:2 Changed 9 years ago by anonymous

  • Component changed from Admin interface to Translations
  • milestone set to Version 1.1
  • priority changed from normal to low
  • Severity changed from normal to minor
  • Type changed from defect to task

comment:3 Changed 9 years ago by anonymous

  • Component changed from Translations to RSS framework
  • milestone changed from Version 1.1 to Version 1.0
  • priority changed from low to high
  • Severity changed from minor to major
  • Type changed from task to defect
  • Version set to new-admin

comment:4 Changed 9 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top