Opened 6 years ago

Closed 3 years ago

#13813 closed Bug (fixed)

Comparison of database connections can raise AttributeError

Reported by: Michael Shields Owned by: Łukasz Balcerzak
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: mshields@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Database connections can raise AttributeError if compared to objects of other types—for example, a partial mock. Normally in Python it is ok to compare any two objects.

Attachments (1)

13818.diff (559 bytes) - added by Michael Shields 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Russell Keith-Magee

Component: UncategorizedDatabase layer (models, ORM)
Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

I take it your patch is actually the reverse?

Also - patch requires tests.

Changed 6 years ago by Michael Shields

Attachment: 13818.diff added

comment:2 Changed 6 years ago by Michael Shields

Patch needs improvement: unset

Sorry, patch is in the correct order now.

comment:3 Changed 6 years ago by Michael Shields

Cc: mshields@… added

comment:4 Changed 6 years ago by Graham King

Severity: Normal
Type: Bug

comment:5 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:6 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:7 Changed 4 years ago by Łukasz Balcerzak

Owner: changed from nobody to Łukasz Balcerzak
Status: newassigned

comment:8 Changed 4 years ago by Łukasz Balcerzak

Has patch: unset
Needs tests: unset
Version: 1.2master

comment:9 Changed 3 years ago by anonymous

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
Back to Top