Opened 14 years ago

Closed 11 years ago

#13813 closed Bug (fixed)

Comparison of database connections can raise AttributeError

Reported by: Michael Shields Owned by: Łukasz Balcerzak
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: mshields@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Database connections can raise AttributeError if compared to objects of other types—for example, a partial mock. Normally in Python it is ok to compare any two objects.

Attachments (1)

13818.diff​ (559 bytes ) - added by Michael Shields 14 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Russell Keith-Magee, 14 years ago

Component: Uncategorized → Database layer (models, ORM)
Needs tests: set
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

I take it your patch is actually the reverse?

Also - patch requires tests.

by Michael Shields, 14 years ago

Attachment: 13818.diff​ added

comment:2 by Michael Shields, 14 years ago

Patch needs improvement: unset

Sorry, patch is in the correct order now.

comment:3 by Michael Shields, 14 years ago

Cc: mshields@… added

comment:4 by Graham King, 13 years ago

Severity: → Normal
Type: → Bug

comment:5 by Aymeric Augustin, 12 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:6 by Aymeric Augustin, 12 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:7 by Łukasz Balcerzak, 11 years ago

Owner: changed from nobody to Łukasz Balcerzak
Status: new → assigned

comment:8 by Łukasz Balcerzak, 11 years ago

Has patch: unset
Needs tests: unset
Version: 1.2 → master

I've created pull request: ​https://github.com/django/django/pull/1183

comment:9 by anonymous, 11 years ago

Resolution: → fixed
Status: assigned → closed

Fixed in 626fa28878b1167d20d2419d68d561297390510a

Note: See TracTickets for help on using tickets.
Back to Top