Opened 14 years ago
Closed 11 years ago
#13813 closed Bug (fixed)
Comparison of database connections can raise AttributeError
Reported by: | Michael Shields | Owned by: | Łukasz Balcerzak |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | mshields@… | Triage Stage: | Accepted |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Database connections can raise AttributeError if compared to objects of other types—for example, a partial mock. Normally in Python it is ok to compare any two objects.
Attachments (1)
Change History (10)
comment:1 by , 14 years ago
Component: | Uncategorized → Database layer (models, ORM) |
---|---|
Needs tests: | set |
Patch needs improvement: | set |
Triage Stage: | Unreviewed → Accepted |
by , 14 years ago
Attachment: | 13818.diff added |
---|
comment:2 by , 14 years ago
Patch needs improvement: | unset |
---|
Sorry, patch is in the correct order now.
comment:3 by , 14 years ago
Cc: | added |
---|
comment:4 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → Bug |
comment:7 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:8 by , 11 years ago
Has patch: | unset |
---|---|
Needs tests: | unset |
Version: | 1.2 → master |
I've created pull request: https://github.com/django/django/pull/1183
comment:9 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I take it your patch is actually the reverse?
Also - patch requires tests.