Opened 6 years ago

Closed 3 years ago

#13813 closed Bug (fixed)

Comparison of database connections can raise AttributeError

Reported by: shields Owned by: LukaszBalcerzak
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: mshields@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Database connections can raise AttributeError if compared to objects of other types—for example, a partial mock. Normally in Python it is ok to compare any two objects.

Attachments (1)

13818.diff (559 bytes) - added by shields 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by russellm

  • Component changed from Uncategorized to Database layer (models, ORM)
  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

I take it your patch is actually the reverse?

Also - patch requires tests.

Changed 6 years ago by shields

comment:2 Changed 6 years ago by shields

  • Patch needs improvement unset

Sorry, patch is in the correct order now.

comment:3 Changed 6 years ago by shields

  • Cc mshields@… added

comment:4 Changed 5 years ago by graham_king

  • Severity set to Normal
  • Type set to Bug

comment:5 Changed 4 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:6 Changed 4 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:7 Changed 3 years ago by LukaszBalcerzak

  • Owner changed from nobody to LukaszBalcerzak
  • Status changed from new to assigned

comment:8 Changed 3 years ago by LukaszBalcerzak

  • Has patch unset
  • Needs tests unset
  • Version changed from 1.2 to master

comment:9 Changed 3 years ago by anonymous

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.
Back to Top