Docs for CurrentSiteManager indicate an M2M field called "sites" will be auto-detected on a model when it won't
|Reported by:||gabrielhurley||Owned by:||gabrielhurley|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Throughout the Sites Framework docs the example models use sites = ManyToManyField(Site), and under the CurrentSiteManager section it indicates that CurrentSiteManager will be able to automatically discover either a ForeignKey called "site" or a ManyToManyField called "sites", when in fact the code only looks for a field called "site".
While it'd be an easy docs fix, it seems more valuable to fix the code for the manager to actually do what the docs say.
I'm happy to write up a patch and tests for it later.
Change History (7)
comment:1 Changed 5 years ago by russellm
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted
Changed 5 years ago by gabrielhurley
comment:2 Changed 5 years ago by gabrielhurley
- Has patch set
- Owner changed from nobody to gabrielhurley
- Status changed from new to assigned
comment:4 Changed 5 years ago by Honza_Kral
- Resolution set to fixed
- Status changed from assigned to closed