Code

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13754 closed (fixed)

Add a note about a test client session property gotcha

Reported by: SmileyChris Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I've tripped over this just now, and remember having the issue a while ago too.

A new session object is retrieved every time the client.session property is called
This means the following code will fail:

self.client.session['somekey'] = something
self.client.session.save()

A note in documentation would be useful.

Attachments (1)

13754.diff (792 bytes) - added by SmileyChris 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by SmileyChris

comment:1 Changed 4 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 4 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from new to closed

(In [13685]) Fixed #13754 - Add a note about a test client session property gotcha

Thanks SmileyChris for report and patch.

comment:3 Changed 4 years ago by lukeplant

(In [13686]) [1.2.X] Fixed #13754 - Add a note about a test client session property gotcha

Thanks SmileyChris for report and patch.

Backport of [13685] from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.