Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#13723 closed (fixed)

Links in error lists looks bad [PATCH]

Reported by: Sebastian Noack Owned by: nobody
Component: contrib.admin Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

By passing a SafeString to the ValidationError, you can include markup in your error messages. This quite useful, escpecially to put links to more detailed explanations in the error message. But even though the error messages are styled white on red background, the links are rendered just in their default color (blue), which looks really bad and is nearly unreadable on red background. I have added a patch, that styles those links white with an underscrore, to make them recognized as link by the user.

Attachments (1)

admin_more_readable_links_in_errorlist.patch​ (510 bytes ) - added by Sebastian Noack 14 years ago.

Download all attachments as: .zip

Change History (5)

by Sebastian Noack, 14 years ago

Attachment: admin_more_readable_links_in_errorlist.patch​ added

comment:1 by Jacob, 14 years ago

milestone: → 1.3
Triage Stage: Unreviewed → Ready for checkin

comment:2 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

(In [13659]) Fixed #13723 -- Improved the legibility of hyperlinks included in admin validation error messages. Thanks to Sebastian Noack for the suggestion and patch.

comment:3 by Russell Keith-Magee, 14 years ago

(In [13662]) [1.2.X] Fixed #13723 -- Improved the legibility of hyperlinks included in admin validation error messages. Thanks to Sebastian Noack for the suggestion and patch.

Backport of r13659 from trunk.

comment:4 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top