response_change does not consider _popup=1 when saving
|Reported by:||donatook||Owned by:||nobody|
|Severity:||Keywords:||popup response_add response_change dismiss dismissAddAnotherPopup|
|Cc:||Triage Stage:||Design decision needed|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Using Admin interface, after adding a foreign key in popup (with the green plus next to the selectbox), the window is closed and the new value is inserted into the selectbox: this is done by calling "opener.dismissAddAnotherPopup" in the response page (see "admin/options/response_add") when "_popup=1" is in the url.
This does not work when 'changing' a foreign key in popup, because "admin/options/response_change" ignores the "_popup" parameter when saving.
I propose to clone "response_add" behaviour in "response_change" so that a "opener.dismissChangePopup" is called when changing a foreing key in popup.
Change History (4)
comment:1 Changed 6 years ago by joni
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:3 Changed 6 years ago by joni
- Triage Stage changed from Unreviewed to Design decision needed