Opened 14 years ago
Closed 9 years ago
#13694 closed Bug (fixed)
SafeMIMEText argument names incompatible with those from MIMEText
| Reported by: | Dave Naffziger | Owned by: | Ramiro Morales |
|---|---|---|---|
| Component: | Core (Mail) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
This has the impact of breaking legacy calls that used the argument names to assign a value. For example:
txt=SafeMIMEText(message, _subtype ='plain', _charset=charset)
Attachments (2)
Change History (12)
Changed 14 years ago by
| Attachment: | change.diff added |
|---|
comment:1 Changed 13 years ago by
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 Changed 13 years ago by
| Severity: | → Normal |
|---|---|
| Type: | → Bug |
comment:3 Changed 13 years ago by
| Needs tests: | set |
|---|
comment:4 Changed 12 years ago by
| UI/UX: | unset |
|---|
comment:6 Changed 11 years ago by
| Needs tests: | unset |
|---|---|
| Version: | 1.2 → master |
Alternate approach with removal of __init__. I don't think we need more tests here, as this is mostly refactoring.
comment:7 Changed 10 years ago by
| Owner: | changed from nobody to Ramiro Morales |
|---|---|
| Status: | new → assigned |
comment:8 Changed 9 years ago by
| Patch needs improvement: | set |
|---|
Removing __init__ doesn't look like an option anymore as there is much more logic in there now.
comment:10 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Change UI/UX from NULL to False.