Opened 14 years ago
Closed 10 years ago
#13694 closed Bug (fixed)
SafeMIMEText argument names incompatible with those from MIMEText
Reported by: | Dave Naffziger | Owned by: | Ramiro Morales |
---|---|---|---|
Component: | Core (Mail) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
This has the impact of breaking legacy calls that used the argument names to assign a value. For example:
txt=SafeMIMEText(message, _subtype ='plain', _charset=charset)
Attachments (2)
Change History (12)
by , 14 years ago
Attachment: | change.diff added |
---|
comment:1 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → Bug |
comment:3 by , 14 years ago
Needs tests: | set |
---|
comment:4 by , 13 years ago
UI/UX: | unset |
---|
comment:6 by , 12 years ago
Needs tests: | unset |
---|---|
Version: | 1.2 → master |
Alternate approach with removal of __init__
. I don't think we need more tests here, as this is mostly refactoring.
comment:7 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:8 by , 10 years ago
Patch needs improvement: | set |
---|
Removing __init__
doesn't look like an option anymore as there is much more logic in there now.
comment:10 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Change UI/UX from NULL to False.