Opened 14 years ago

Closed 9 years ago

#13694 closed Bug (fixed)

SafeMIMEText argument names incompatible with those from MIMEText

Reported by: Dave Naffziger Owned by: Ramiro Morales
Component: Core (Mail) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

This has the impact of breaking legacy calls that used the argument names to assign a value. For example:

txt=SafeMIMEText(message, _subtype ='plain', _charset=charset)

Attachments (2)

change.diff (1.3 KB ) - added by Dave Naffziger 14 years ago.
13694-2.diff (750 bytes ) - added by Claude Paroz 11 years ago.
Remove init

Download all attachments as: .zip

Change History (12)

by Dave Naffziger, 14 years ago

Attachment: change.diff added

comment:1 by Russell Keith-Magee, 14 years ago

Triage Stage: UnreviewedAccepted

comment:2 by Julien Phalip, 13 years ago

Severity: Normal
Type: Bug

comment:3 by Julien Phalip, 13 years ago

Needs tests: set

comment:4 by Aymeric Augustin, 12 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 by Aymeric Augustin, 12 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

by Claude Paroz, 11 years ago

Attachment: 13694-2.diff added

Remove init

comment:6 by Claude Paroz, 11 years ago

Needs tests: unset
Version: 1.2master

Alternate approach with removal of __init__. I don't think we need more tests here, as this is mostly refactoring.

comment:7 by Ramiro Morales, 11 years ago

Owner: changed from nobody to Ramiro Morales
Status: newassigned

comment:8 by Tim Graham, 10 years ago

Patch needs improvement: set

Removing __init__ doesn't look like an option anymore as there is much more logic in there now.

comment:10 by Tim Graham <timograham@…>, 9 years ago

Resolution: fixed
Status: assignedclosed

In a5bd7f2cb2ce6d9cf309748be0fe033b836c4507:

Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.

Note: See TracTickets for help on using tickets.
Back to Top