Opened 6 years ago

Closed 23 months ago

#13694 closed Bug (fixed)

SafeMIMEText argument names incompatible with those from MIMEText

Reported by: Dave Naffziger Owned by: Ramiro Morales
Component: Core (Mail) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

This has the impact of breaking legacy calls that used the argument names to assign a value. For example:

txt=SafeMIMEText(message, _subtype ='plain', _charset=charset)

Attachments (2)

change.diff (1.3 KB) - added by Dave Naffziger 6 years ago.
13694-2.diff (750 bytes) - added by Claude Paroz 4 years ago.
Remove init

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by Dave Naffziger

Attachment: change.diff added

comment:1 Changed 6 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 years ago by Julien Phalip

Severity: Normal
Type: Bug

comment:3 Changed 5 years ago by Julien Phalip

Needs tests: set

comment:4 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

Changed 4 years ago by Claude Paroz

Attachment: 13694-2.diff added

Remove init

comment:6 Changed 4 years ago by Claude Paroz

Needs tests: unset
Version: 1.2master

Alternate approach with removal of __init__. I don't think we need more tests here, as this is mostly refactoring.

comment:7 Changed 3 years ago by Ramiro Morales

Owner: changed from nobody to Ramiro Morales
Status: newassigned

comment:8 Changed 2 years ago by Tim Graham

Patch needs improvement: set

Removing __init__ doesn't look like an option anymore as there is much more logic in there now.

comment:10 Changed 23 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In a5bd7f2cb2ce6d9cf309748be0fe033b836c4507:

Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.

Note: See TracTickets for help on using tickets.
Back to Top