Opened 5 years ago

Closed 7 months ago

#13694 closed Bug (fixed)

SafeMIMEText argument names incompatible with those from MIMEText

Reported by: davenaff Owned by: ramiro
Component: Core (Mail) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

This has the impact of breaking legacy calls that used the argument names to assign a value. For example:

txt=SafeMIMEText(message, _subtype ='plain', _charset=charset)

Attachments (2)

change.diff (1.3 KB) - added by davenaff 5 years ago.
13694-2.diff (750 bytes) - added by claudep 3 years ago.
Remove init

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by davenaff

comment:1 Changed 5 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by julien

  • Severity set to Normal
  • Type set to Bug

comment:3 Changed 4 years ago by julien

  • Needs tests set

comment:4 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 3 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

Changed 3 years ago by claudep

Remove init

comment:6 Changed 3 years ago by claudep

  • Needs tests unset
  • Version changed from 1.2 to master

Alternate approach with removal of __init__. I don't think we need more tests here, as this is mostly refactoring.

comment:7 Changed 23 months ago by ramiro

  • Owner changed from nobody to ramiro
  • Status changed from new to assigned

comment:8 Changed 13 months ago by timo

  • Patch needs improvement set

Removing __init__ doesn't look like an option anymore as there is much more logic in there now.

comment:10 Changed 7 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In a5bd7f2cb2ce6d9cf309748be0fe033b836c4507:

Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.

Note: See TracTickets for help on using tickets.
Back to Top