Code

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#13686 closed (fixed)

Asymmetry in memcached.add and memcached.set

Reported by: nedbatchelder Owned by: nobody
Component: Core (Cache system) Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In changeset [12637], conversions to and from utf-8 were removed from .set() and .get(). But .add() still performs the conversion, which seems wrong.

Attachments (2)

add-unicode.patch (1.2 KB) - added by dmedvinsky 3 years ago.
Reattached patch from duplicate ticket by jbalogh
13686_14703_unicode_in_memcached_backend_r14757.diff (2.0 KB) - added by accuser 3 years ago.
Extended patch with fix for #14703

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by russellm

  • milestone set to 1.3
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by kmtracey

#13791 reported the same thing, and has a patch with a test.

Changed 3 years ago by dmedvinsky

Reattached patch from duplicate ticket by jbalogh

comment:3 Changed 3 years ago by dmedvinsky

  • Has patch set

Changed 3 years ago by accuser

Extended patch with fix for #14703

comment:4 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15880]:

Fixed #13686 -- Ensure that memcache handling of unicode values in add() and set_many() is consistent with the handling provided by get() and set(). Thanks to nedbatchelder for the report, and to jbalogh, accuser and Jacob Burch for their work ont the patch.

comment:5 Changed 3 years ago by russellm

In [15881]:

[1.2.X] Fixed #13686 -- Ensure that memcache handling of unicode values in add() and set_many() is consistent with the handling provided by get() and set(). Thanks to nedbatchelder for the report, and to jbalogh, accuser and Jacob Burch for their work ont the patch.

Backport of r15880 from trunk.

comment:6 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.