Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13686 closed (fixed)

Asymmetry in memcached.add and memcached.set

Reported by: Ned Batchelder Owned by: nobody
Component: Core (Cache system) Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In changeset [12637], conversions to and from utf-8 were removed from .set() and .get(). But .add() still performs the conversion, which seems wrong.

Attachments (2)

add-unicode.patch (1.2 KB) - added by dmedvinsky 6 years ago.
Reattached patch from duplicate ticket by jbalogh
13686_14703_unicode_in_memcached_backend_r14757.diff (2.0 KB) - added by Alexey Smolsky 6 years ago.
Extended patch with fix for #14703

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Russell Keith-Magee

milestone: 1.3
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 years ago by Karen Tracey

#13791 reported the same thing, and has a patch with a test.

Changed 6 years ago by dmedvinsky

Attachment: add-unicode.patch added

Reattached patch from duplicate ticket by jbalogh

comment:3 Changed 6 years ago by dmedvinsky

Has patch: set

Changed 6 years ago by Alexey Smolsky

Extended patch with fix for #14703

comment:4 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

In [15880]:

Fixed #13686 -- Ensure that memcache handling of unicode values in add() and set_many() is consistent with the handling provided by get() and set(). Thanks to nedbatchelder for the report, and to jbalogh, accuser and Jacob Burch for their work ont the patch.

comment:5 Changed 6 years ago by Russell Keith-Magee

In [15881]:

(The changeset message doesn't reference this ticket)

comment:6 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top