forms.URLField not default ModelForm URLField anymore

[amadison]

Looks like with Changeset 11456 the ModelForm URLField stopped using the forms.FormField as it's default form field. Now it just uses a regular CharField but adds the validators.URLValidator.

There are two important things that were lost when this happened.

1. the ModelForm does not add on the '​http://' if it is not present, so 'www.google.com' is an invalid url when using a ModelForm, but not a regular form.
2. The error message on an invalid url is now the generic 'Enter a valid value.' instead of the more helpful 'Enter a valid URL.'.

Attached is a diff for making the ModelForm URLField use the default forms.URLField again as the docs describe ​here

I think this will make the validator run twice, but I think that's probably ok.

[anonymous]

it is really a bug

[Leo Shklovskii]

+1 for a fix, ideally in a 1.2.x release.

We're running into this bug as well since upgrading to 1.2.

[John-Scott Atlakson]

Closed #13744 as a duplicate of this ticket.

Note to self, search open tickets before debugging Django as you can be sure someone has already created a ticket with the exact same patch two months prior.

[Russell Keith-Magee]

(In [13475]) Fixed #13613 -- Ensure that forms.URLField and forms.EmailField are used on a modelform. This ensures that fields are URL and Email fields are cleaned consistently when included on model forms. Thanks to amadison for the report.

[Russell Keith-Magee]

(In [13476]) [1.2.X] Fixed #13613 -- Ensure that forms.URLField and forms.EmailField are used on a modelform. This ensures that fields are URL and Email fields are cleaned consistently when included on model forms. Thanks to amadison for the report.

Backport of r13475 from trunk.

[Jacob]

Milestone 1.3 deleted