Opened 6 years ago

Closed 4 years ago

#13581 closed Cleanup/optimization (wontfix)

improve naming of default coordinates for GeoModelAdmin¶

Reported by: Tyler Erickson Owned by: nobody
Component: GIS Version: 1.1
Severity: Normal Keywords: GeoModelAdmin
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The GeoModelAdmin class currently has properties of default_lon and default_lat. While these are reasonable names when using an unprojected coordinate system, they are misleading if a subclass with another projection is used (such as the spherical mercator projection used by the class OSMGeoAdmin). This may lead to confused users, for example: http://code.djangoproject.com/ticket/11094.

I would suggest changing the default coordinate names to default_x and default_y.

Change History (5)

comment:1 Changed 6 years ago by Russell Keith-Magee

Component: UncategorizedGIS
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 5 years ago by Julien Phalip

Severity: Normal
Type: Cleanup/optimization

comment:3 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:4 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:5 Changed 4 years ago by Aymeric Augustin

Resolution: wontfix
Status: newclosed

This isn't obviously worth the backwards incompatibility.

Note: See TracTickets for help on using tickets.
Back to Top