#13577 closed (fixed)
New Polish L10N formats file
Reported by: | Ludwik Trammer | Owned by: | Łukasz Rekucki |
---|---|---|---|
Component: | Translations | Version: | 1.2 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
Updated Polish formats.py file, taking advantage of new L10N features in Djnago 1.2.
Attachments (2)
Change History (19)
by , 14 years ago
Attachment: | polish_formats.diff added |
---|
comment:1 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:3 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Thousand separator should be ' ' (space) instead of '.' (dot). The old one was good.
comment:5 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
follow-up: 7 comment:6 by , 14 years ago
Replying to sero:
I believe both formats are valid. I have nothing against changing it to space, but it would have to be a non-breaking space (there is nothing worst then a line break in the middle of a number). My first instinct would be to just put " " there, but I don't think it would be a good solution. The problem is those formats can probably be used outside of HTML space, so using an HTML entity could break things...
comment:7 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Replying to ludwik:
I believe both formats are valid.
Don't know about the dot, by the typesetting standard (PN-83) says it it should be a 2pt. width space.
I have nothing against changing it to space, but it would have to be a non-breaking space (there is nothing worst then a line break in the middle of a number). My first instinct would be to just put " " there, but I don't think it would be a good solution. The problem is those formats can probably be used outside of HTML space, so using an HTML entity could break things...
Check out unicode character "\u2009" ( ). It has the right width and it's recomended as a thousands separator. AFAIR, Django templates are always unicode, so it could do the trick. I agree with you that an ordinary space is a bit confusing and will cause problems with line breaks, so I think I'll open this again.
comment:8 by , 14 years ago
Triage Stage: | Ready for checkin → Accepted |
---|
comment:10 by , 14 years ago
Owner: | removed |
---|---|
Status: | reopened → new |
comment:11 by , 14 years ago
milestone: | → 1.3 |
---|---|
Owner: | set to |
comment:12 by , 14 years ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
FYI - The only thing holding this back from 1.3 is a consensus on the right solution. The patch is still using a dot; discussion seems to suggest that Polish standards indicate a nonbreakable space is appropriate.
If someone can resolve this discussion (and update the patch if required), please mark RFC and I'll commit.
comment:13 by , 14 years ago
Just checked in CLDR data set, Polish has non-breaking space as thousand separator.
comment:14 by , 14 years ago
For thinsp / against nbsp:
- It honors the standard PN-83 which is polish typesetting standard (which I currently don't have access to, and my Google-fu is failing)
For nbsp / against thinsp:
- the unbreaking behaviour is desirable
- thinsp seems esoteric to me (please correct me if I'm wrong)
- this page says Opera doesn't display thinsp properly: http://en.wikipedia.org/wiki/Template:Thinsp
- CLDR data set confirms this option
I'd say use nbsp. I'm happy with submitting a patch, but I'm not sure if putting unicode there wouldn't break things.
by , 14 years ago
Attachment: | polish_formats.2.diff added |
---|
nbsp as thousand separator for polish locale
comment:16 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Uh, closing, this shouldn't have been reopened in the first place because there was a commit already.
(In [13298]) Fixed #13577 -- Updated Polish formats file. Thanks, ludwik.