Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#13524 closed (fixed)

Changes to (model) formsets' max_num sematics not listed in the 1.2 release notes

Reported by: Ramiro Morales Owned by: nobody
Component: Documentation Version: 1.2-beta
Severity: Keywords: max_num
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

After a couple of threads in the django-es and django-users mailing lists (that also gave bith to #13521/r13234) it seemed clear we aren't documenting in the release notes the backward incompatible changes implemented in r12872 that affect usage of formsets, model formsets and admin inlines.

The patch attached tries to fix that. Any help reviewing the language used and fleshing it out with more content especially by people more familiar with the changes implemented in such commits will be greatly appreciated.

The patch also:

  • Moves a note about the admin inlines JS-powered 'Add another' link from the formsets docs to the admin docs because that seem the place where it belongs. It doesn't even belog in the model formsets docs.
  • Add a few tests and fixes typos to the formsets and model formsets I created when trying to understand and confirm the new behavior.

Setting milestone = 1.2.

Attachments (3)

13524.1.diff (9.9 KB ) - added by Ramiro Morales 14 years ago.
First iteration of this patch, enhancements welcome
13524.2.diff (9.9 KB ) - added by Ramiro Morales 14 years ago.
Fixed two typos
13524.3.diff (10.1 KB ) - added by Gabriel Hurley 14 years ago.
Corrects two more typos, adds a couple grammatical changes for readability

Download all attachments as: .zip

Change History (6)

by Ramiro Morales, 14 years ago

Attachment: 13524.1.diff added

First iteration of this patch, enhancements welcome

by Ramiro Morales, 14 years ago

Attachment: 13524.2.diff added

Fixed two typos

by Gabriel Hurley, 14 years ago

Attachment: 13524.3.diff added

Corrects two more typos, adds a couple grammatical changes for readability

comment:1 by Russell Keith-Magee, 14 years ago

Triage Stage: UnreviewedReady for checkin
Version: 1.11.2-beta

comment:2 by Russell Keith-Magee, 14 years ago

Resolution: fixed
Status: newclosed

(In [13241]) Fixed #13524 -- Added backwards compatibility and feature notes regarding admin inlines and formsets. Thanks to Ramiro Morales and Gabriel Hurley.

comment:3 by Jacob, 12 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top