Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#13495 closed (fixed)

Refactoring of localflavor regression tests

Reported by: chronos Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords: localflavor, unittests, refactoring, country, countries, locations, location
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

After put #13473 working, I'll write unit tests, but tests/regressiontests/localflavor/ isn't prepared to receive more countries. I re-factored localflavor tests to support add more countries, and renamed localflavor directory to localflavor_regress (as Russ suggested in #django-dev some days ago) to avoid any chance of conflict with django.contrib.localflavor.

Patch are attached.

Attachments (1)

ticket13495.patch (10.7 KB) - added by chronos 4 years ago.
Refactoring of localflavor tests. Maybe is better check structure here: http://1l.to/g1e

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by chronos

Refactoring of localflavor tests. Maybe is better check structure here: http://1l.to/g1e

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [13505]) Fixed #13495 -- Refactored the localflavor test directory to provide the placeholder structure for other flavors. Thanks to chronos for the report and patch.

comment:3 Changed 4 years ago by russellm

(In [13506]) [1.2.X] Fixed #13495 -- Refactored the localflavor test directory to provide the placeholder structure for other flavors. Thanks to chronos for the report and patch.

Backport of r13505 from trunk.

comment:4 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.