Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13348 closed (fixed)

After r12950, load_app does not return models modules from eggs

Reported by: Karen Tracey Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

#13334 points out a problem loading template tags from eggs. Since the change (to use imp.find_module) that introduced that problem was the inspiration for r12950, the r12950 code has the same problem, only for r12950 the problem involves loading models modules from apps in eggs. Ramiro pointed to a patch on #9427 that attempts to find modules loaded by eggs, but I could not quite get that code to work. I'll attach a patch that I did get to work, with tests. This patch introduces a utility function to answer the question: does this loaded module have a submodule named x? This seems to be something we could use in a few places.

Attachments (4)

egg_loading.diff (6.4 KB) - added by Karen Tracey 6 years ago.
modelapp.egg (3.3 KB) - added by Karen Tracey 6 years ago.
nomodelapp.egg (3.6 KB) - added by Karen Tracey 6 years ago.
omelet.egg (8.8 KB) - added by Karen Tracey 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by Karen Tracey

Attachment: egg_loading.diff added

Changed 6 years ago by Karen Tracey

Attachment: modelapp.egg added

Changed 6 years ago by Karen Tracey

Attachment: nomodelapp.egg added

Changed 6 years ago by Karen Tracey

Attachment: omelet.egg added

comment:1 Changed 6 years ago by Karen Tracey

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

The eggs are supposed to be in the diff but they're not. They're supposed to go under tests/regressiontests/app_loading/eggs.

comment:2 Changed 6 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

comment:3 Changed 6 years ago by Karen Tracey

Resolution: fixed
Status: newclosed

(In [12982]) Fixed #13348: Restored ability to load models from apps in eggs. Thanks Ramiro and metzen for pointers on how to find out if a module loaded from an egg has a particular submodule.

comment:4 Changed 6 years ago by Karen Tracey

(In [12983]) [1.1.X] Fixed #13348: Restored ability to load models from apps in eggs. Thanks Ramiro and metzen for pointers on how to find out if a module loaded from an egg has a particular submodule.

r12982 from trunk.

comment:5 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top