Code

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#1331 closed defect (fixed)

[magic-removal][patch] flatten_data method of ManyToManyField is broken with descriptor changes

Reported by: Tom Tobin <korpios@…> Owned by: adrian
Component: Core (Other) Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The flatten_data method of ManyToManyField is currently broken in magic-removal (as of r2279), as the code attempts to use an old-style get_something_list method rather than the new-style descriptor and all(). The attached patch fixes this issue.

Attachments (1)

magic_removal-manytomany_flatten_data_fix.diff (709 bytes) - added by Tom Tobin <korpios@…> 8 years ago.
fixes flatten_data method of ManyToManyField in magic-removal

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Tom Tobin <korpios@…>

fixes flatten_data method of ManyToManyField in magic-removal

comment:1 Changed 8 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from new to closed

(In [2281]) magic-removal: Fixed #1331 - flatten_data method of ManyToManyField now
updated for descriptor changes. Thanks, Tom Tobin.

comment:2 Changed 7 years ago by korpios

  • Reporter changed from Tom Tobin <korpios@…> to Tom Tobin <korpios@…>

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.