Remove useless whitespaces in JSON dump with indent option

[Stephane Raimbault]

When a JSON dump is done with the indent option, all lines are terminated by a whitespace and a newline.
The trailing whitespace is useless, it increases the file size and emits a warning in my editor and git.

The goal of my patch is to remove these whitespaces (specific to the JSON serializer).

[Stephane Raimbault]

Remove trailing whitespace and cosmetic changes (import of get_models, spaces)

[David Novakovic]

New patch with tests attached.

[gptvnt]

I tested the latest patch and ran the test. It seems to be working fine. I have attached the data dump I got in both the cases (with and without the patch) while testing.

[Julien Phalip]

The patch looks great. I've just updated it to work with current trunk and rejigged the comments a little.

[anonymous]

As of ​v2.1.5. this is fixed in simplejson.

[Jacob]

In that case I'm going to mark this wontfix. An explicitly installed simplejson will override the one Django ships with, so if you care about this then just pip install simplejson

[hekevintran@…]

This ticket should be reconsidered because Django 1.5 has removed its copy of simplejson in favour of json from Python's standard library (which is based on version 2.0.9 of simplejson). As a result there is no way to prevent having trailing whitespace in when using the JSON serializer.

See ​https://docs.djangoproject.com/en/dev/releases/1.5/#system-version-of-simplejson-no-longer-used

[Aymeric Augustin]

Unfortunately the patch doesn't apply any longer, so this isn't RFC.

[martmatwarne]

Removing the two lines in the diff fixes the issue. I can't think of a reason why you'd want to have a blank line at the bottom but correct me if I'm wrong.

[martmatwarne]

Actually this doesn't completely work as it will mean when you do a command such as dumpdata that your prompt doesn't go to the next line

[pjmattal]

Updated to apply to master. Serialize tests pass.

[Claude Paroz <claude@…>]

In 3e34005b1b4a9a447e3b3fd76e71f0c73d530414:

Fixed #13182 -- Prevented trailing spaces in indented json output

Thanks Stéphane Raimbault for the report and the initial patch.

[Ramiro Morales <cramm0@…>]

In c01cd4c4234368b050cb872defe5f16597db4bdb:

Change test added in 3e34005b1b to be more stable.

It could fail when actual serialization JSON field ordering was
different from the hard-coded one. Refs #13182.