Opened 7 years ago

Closed 6 years ago

#13158 closed (fixed)

Documentation still says to use ForeignKey with unique=True to add a UserProfile

Reported by: Harro Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The documentation says to extend the user model you should add a profile model with a foreignkey with unique=True to the user.

Is there a reason for doing this instead of a OneToOne field?

The OneToOne field has the advantage that you can get the profile for the user directly.

Attachments (1)

ticket13158.diff (1.0 KB) - added by Harro 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

There's no specific reason. Patch welcome.

Changed 7 years ago by Harro

Attachment: ticket13158.diff added

comment:2 Changed 7 years ago by Harro

Has patch: set

Patch added.

comment:3 Changed 6 years ago by Adam Nelson

Triage Stage: AcceptedReady for checkin

The disadvantage of this approach is that you only have one profile per user. Nonetheless, the patch is fine and it's been approved.

comment:4 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [13197]) Fixed #13158 -- Clarified that OneToOneField is a better option for User profile classes. Thanks to hvdklauw for the report and patch.

Note: See TracTickets for help on using tickets.
Back to Top