Opened 13 years ago
Closed 7 years ago
#13146 closed New feature (wontfix)
Remove hardcoded stuff in contrib.admin
| Reported by: | utku | Owned by: | utku |
|---|---|---|---|
| Component: | contrib.admin | Version: | 1.1 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description
There're lots of unnecessary hardcoded elements with the Admin which makes it hard to customize. Some examples:
http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/widgets.py#L126 (hardcoded image)
http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/widgets.py#L95 (template/widget instead)
http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L650 (move to template)
http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/widgets.py#L238 (hardcoded image, including width and height, this should go to CSS)
IMO, getting rid of almost all hardcoded elements is the base for a more extensible, customizable and easier to change/adapt interface (PK).
Change History (11)
comment:1 Changed 13 years ago by
| Component: | django.contrib.admin → User Experience |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 Changed 13 years ago by
| milestone: | → 1.3 |
|---|
comment:3 Changed 12 years ago by
| milestone: | 1.3 |
|---|
This is a fine idea, but without a patch this has no chance to make it in 1.3. Also, the line numbers in your description are probably outdated. It'd be useful if you could provide more details about those hardcoded things you're actually referencing.
comment:4 Changed 12 years ago by
| Type: | → New feature |
|---|
comment:5 Changed 12 years ago by
| Severity: | → Normal |
|---|
comment:6 Changed 12 years ago by
| UI/UX: | set |
|---|
comment:7 Changed 12 years ago by
| Component: | User Experience → contrib.admin |
|---|
comment:11 Changed 7 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
The admin has been recently refactored with a new design. IMHO this ticket is nowadays unfortunately no longer actionable. Feel free to open new tickets with more descriptive stuff.
Seems easy enough to fix and make people's lives easier.