#13126 closed (fixed)
admin list_editable with unique_together error indication
| Reported by: | Sławek Ehlert | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | list_editable unique_together custom validation error | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
this is somehow related to #13091
When using list_editable in case when all fields from unique_together are in list_editable, the error message does show. However it isn't very informative (only "Please correct the errors below." but nothing below is indicated).
Done this on sqlite3 and PostgreSQL.
Attachments (2)
Change History (12)
comment:1 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 15 years ago
| Keywords: | custom validation added |
|---|
I noticed that this issue is related to other (custom) validation rules also. Not only the uniqueness of a model.
When I have some custom validation logic in model's clean method the behaviour is the same. Maybe we should reconsider changing the title of this ticket. Isn't this a candidate for a 1.2 milestone?
comment:3 by , 15 years ago
| milestone: | → 1.3 |
|---|
No need to change the ticket title - the title isn't the be-all and end-all of the reporting process, it's just a helpful reminder.
This isn't 1.2 critical - the validation is still occurring, so there's no risk of data loss. I will fully admit that not getting validation error messages is a really annoying bug, but we can live without it. However, I will put it onto the 1.3 milestone so it gets priority next time around.
by , 14 years ago
| Attachment: | 13126_changelist_non_field_errors.diff added |
|---|
comment:4 by , 14 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
The issue here is that currently the non_field_errors are never displayed for each form in the changelist's formset. The attached patch should fix this. I'm promoting to RFC hoping this bug gets a core dev's attention before 1.3 lands (which is pretty soon) ;-)
by , 14 years ago
| Attachment: | 13126_changelist_non_field_errors.2.diff added |
|---|
Slightly more robust tests
comment:5 by , 14 years ago
If you're interested in this ticket, I recommend you to also check #13091, which I think should also be RFC.
To clarify - the issue here is that an object level (as opposed to field level) validation error isn't rendered. If you have a model with list_editable in admin, and you try to edit an object to violate a unique_together clause, you get the generic top level error, but no error on the object row itself.