Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#13124 closed (fixed)

function 'find_template_loader' doesn't work with PyPy 1.2

Reported by: avostryakov Owned by: nobody
Component: Template system Version: 1.2-beta
Severity: Keywords: find template, pypy
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

I tested django template system under PyPy 1.2. Basically it works except one small line of code in function 'find_template_loader; (<root project's directory>/django/template/loader.py):

'if hasattr(loader, 'iter'):'

I suggest to replace this line with:

'if isinstance(loader, tuple):'

The patch is attached. I think it'll be better because a new code doesn't use a little tricky feature of python. Class 'string' doesn't have 'iter' attribute but can be iterated.

Attachments (1)

find_template_loader_patch.diff (417 bytes) - added by avostryakov 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by avostryakov

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

The test should be extended to also allow for lists, but otherwise a reasonable suggestion.

comment:2 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [12805]) Fixed #13123 -- Cleaned up template loader for PyPy compatibility. Thanks to avostryakov for the report.

comment:3 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.