Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#13082 closed (fixed)

Oracle-specific test_long_string backends regression test has a bug

Reported by: stvsmth Owned by: nobody
Component: Database layer (models, ORM) Version: 1.1
Severity: Keywords: regression backends oracle clob nclob
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


In the process of tracking down an Oracle CLOB encoding issue (to be created in another ticket once I get my head around it), I think I've found a bug in the test_long_string regression test. Since this is an Oracle-specific test I am guessing it doesn't get exercised that often.

The test writes a long string to the database then reads it to ensure there are no round-trip encoding issues. The test appears to drop the table before the read happens. You can see this bug by changing the xrange(4000) portion of the test to xrange(40).

ERROR: test_long_string (regressiontests.backends.tests.LongString)
Traceback (most recent call last):
  File "/Users/stvsmth/code/workspaces/django-trunk/tests/regressiontests/backends/", line 38, in test_long_string
    self.assertEquals(long_str, row[0].read())
DatabaseError: ORA-00942: table or view does not exist

It looks like the read is lazy, so the drop table command needs to happen after the read:

36             row = c.fetchone()
37             c.execute('DROP TABLE ltext')
38             self.assertEquals(long_str, row[0].read())

The attached patch makes this simple change.

Ran 6 tests in 0.245s

Attachments (1)

test_long_string_fix.diff (594 bytes) - added by stvsmth 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by stvsmth

Attachment: test_long_string_fix.diff added

comment:1 Changed 9 years ago by Russell Keith-Magee

Component: Testing frameworkDatabase layer (models, ORM)
milestone: 1.2
Triage Stage: UnreviewedAccepted

If this is a regression, it needs to be addressed for 1.2

comment:2 Changed 9 years ago by Ramiro Morales

Summary: Backends test_long_string regression test has a bugOracle-specific test_long_string backends regression test has a bug

comment:3 Changed 9 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12913]) Fixed #13082 -- Slight modification to an Oracle test to avoid a problem cause by teardown behavior. Thanks to stvsmth for the report and patch.

comment:4 Changed 7 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top