Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#13071 closed (fixed)

NullBooleanField save error in Admin?

Reported by: Ed Hagen Owned by: nobody
Component: Contrib apps Version: 1.2-beta
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


I have a model field defined thus:

benefit = models.NullBooleanField()

In django 1.1 and 1.2 pre-alpha, nulls were displayed with a "?" icon
in list view. In the Admin change form, a pop-up menu appeared with 3
options (Unknown, Yes, No). Setting to "Unknown" and saving did not
generate any errors.

I then updated to django 1.2 beta 1 SVN-12738. Nulls are now
displayed with "(None)". When I try and set this field to "Unknown"
using the popup menu, and then save in the Admin, I get the following

"This field cannot be blank."

I get this same error when I try and add a new record in the Admin.

I am using python 2.5.1 on Mac OS X and sqlite3.

Change History (6)

comment:1 Changed 7 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by James Bennett

(In [12744]) Forced blank=True for NullBooleanField to allow it to pass model validation with a value of None. Refs #13071.

comment:3 Changed 7 years ago by James Bennett

(In [12745]) Tests for [12744], which were accidentally left out of the commit. Refs #13071.

comment:4 Changed 7 years ago by James Bennett

(In [12746]) Ensure that NullBooleanField displays the appropriate icon for null values in admin changelists. Refs #13071.

comment:5 Changed 7 years ago by James Bennett

Resolution: fixed
Status: newclosed

Between those two patches, this should now be fixed.

comment:6 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top