Opened 5 years ago

Closed 5 years ago

#13058 closed (fixed)

New built-in "smart if" template tag doesn't support "if not in ..." condition

Reported by: ramusus Owned by: lukeplant
Component: Template system Version: 1.1
Severity: Keywords:
Cc: ramusus@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

One thing is prevent to switch completely from old smart if snippet to new smart if built-in template tag is "if not in ..." condition. This works in snippet, but in built-in template tag doesn't. It's important condition and very strange that this functionality lost while migration of templatetag to trunk.

Change History (3)

comment:1 Changed 5 years ago by ramusus

  • Cc ramusus@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by lukeplant

  • Owner changed from nobody to lukeplant
  • Status changed from new to assigned

It was lost because:

  • the parser was rewritten completely
  • in the new parser it is slightly harder to add 'not in' because it involves two tokens
  • I didn't realise the old snippet supported 'not in'

I will commit a fix soon.

comment:3 Changed 5 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12732]) Fixed #13058 - "smart if" template tag doesn't support "if not in ..." condition

Thanks to ramusus for the report.

Note: See TracTickets for help on using tickets.
Back to Top