ModelForm clean() is ignored

[Patryk Zawadzki]

In 1.2 when you validate a form the logic is as follows:

• BaseForm's full_clean() is called
• ModelForm's _clean_fields() is called
  • it calls each field's clean_FOO()
  • it calls construct_instance and at this point assigns all values to the instance
• BaseForm's _clean_form() is called
  • it calls clean()

At this point clean() can update self.cleaned_data but the value is never used for anything. This breaks forms that rely on clean() being able to alter the data (useful for example when a field's value depends on other fields). The instance should at least be updated when calling save().

[jkocherhans]

Duplicate of #12960.

[Jacob]

Milestone 1.2 deleted