#12932 closed (fixed)
Django Test runner suite_result should be passed in the suite.
| Reported by: | Eric Holscher | Owned by: | nobody |
|---|---|---|---|
| Component: | Testing framework | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I have a use case where I want need the suite in the use of reporting the result. Currently I have to subclass all of run_tests to get at it:
It also seems like allowing some (or all) of these functions should take kwargs, so that when we find stuff like this in the future it doesn't break backwards compatibility. Stuff like setup_test_environment might not, because it's just a basic wrapper, but it seems like a good future-proofing step.
Attached is a patch that does this.
Attachments (1)
Change History (4)
by , 14 years ago
| Attachment: | django_12932.diff added |
|---|
comment:1 by , 14 years ago
| Component: | Uncategorized → Testing framework |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
(In [12487]) Fixed #12932 -- Added an extra argument to suite_result() in the test runner, and added kwargs as protection against future changes. Thanks to Eric Holscher for the report and patch.
This is BACKWARDS INCOMPATIBLE for anyone that has written a custom DjangoTestRunner class since it was introduced in r12255.