Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12932 closed (fixed)

Django Test runner suite_result should be passed in the suite.

Reported by: Eric Holscher Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I have a use case where I want need the suite in the use of reporting the result. Currently I have to subclass all of run_tests to get at it:

http://github.com/ericholscher/pony_utils/blob/50355eaab2ae42e327a06380d975fae9ab33e19b/pony_utils/django/test_runner.py#L16

It also seems like allowing some (or all) of these functions should take kwargs, so that when we find stuff like this in the future it doesn't break backwards compatibility. Stuff like setup_test_environment might not, because it's just a basic wrapper, but it seems like a good future-proofing step.

Attached is a patch that does this.

Attachments (1)

django_12932.diff (2.8 KB) - added by Eric Holscher 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Eric Holscher

Attachment: django_12932.diff added

comment:1 Changed 7 years ago by Jannis Leidel

Component: UncategorizedTesting framework
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12487]) Fixed #12932 -- Added an extra argument to suite_result() in the test runner, and added kwargs as protection against future changes. Thanks to Eric Holscher for the report and patch.

This is BACKWARDS INCOMPATIBLE for anyone that has written a custom DjangoTestRunner class since it was introduced in r12255.

comment:3 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top