Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#12878 closed (fixed)

Formset wide errors are not properly rendered in the template

Reported by: KyleMac Owned by: matiasb
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Errors raised by a FormSet's clean() method are converted straight to strings and rendered along the lines of "[u'This is an error.']" instead of being iterated over and styled properly.

Attachments (2)

12878-1.diff (2.0 KB) - added by matiasb 6 years ago.
Fixed formsets to set non_form_errors as errorlist after a full_clean
12878-2.diff (2.8 KB) - added by matiasb 6 years ago.
Updated previous patch to add general formset test

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by matiasb

  • Owner changed from nobody to matiasb
  • Status changed from new to assigned

Changed 6 years ago by matiasb

Fixed formsets to set non_form_errors as errorlist after a full_clean

comment:3 Changed 6 years ago by matiasb

  • Has patch set

added patch

Changed 6 years ago by matiasb

Updated previous patch to add general formset test

comment:4 Changed 6 years ago by Alex

  • milestone set to 1.2
  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 6 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12548]) Fixed #12878. Formset-wide errors are now rendered properly as html.

comment:6 Changed 6 years ago by jkocherhans

(In [12549]) [1.1.x] Fixed #12878. Formset-wide errors are now rendered properly as html. Backport of r12548 from trunk.

comment:7 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top