Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12868 closed (fixed)

Updated French formats.py

Reported by: stephaner Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Adjustments to the French l10n settings

Attachments (2)

formats.py (1.2 KB) - added by stephaner 5 years ago.
Updated to include fr_CH date inputs
fr-formats.diff (1.5 KB) - added by stephaner 5 years ago.
Updated to include fr_CH date inputs (diff)

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by david

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Looks good to me, set as Accepted given there is no French people in triaging system (as far as I know).

comment:2 Changed 5 years ago by claudep

In Switzerland (fr_CH), we use the dot to separate dates. I wonder if it is worth creating a whole Django locale directory just for that, or if we should just add the format to FORMATS tuples in the fr file. Thoughts?

comment:3 follow-up: Changed 5 years ago by stephaner

Like you, I don't think it's worth creating a whole Django locale for fr_CH (formats.py, django.po and djangojs.po), the change is only on input dates so with a nice comment to mention that Swiss only, I'd prefer to add the Swiss input format rather than create a new locale.

Claude, could you check the new file, please?

Changed 5 years ago by stephaner

Updated to include fr_CH date inputs

Changed 5 years ago by stephaner

Updated to include fr_CH date inputs (diff)

comment:4 Changed 5 years ago by david

  • Triage Stage changed from Accepted to Ready for checkin

comment:5 in reply to: ↑ 3 Changed 5 years ago by claudep

Replying to stephaner:

Claude, could you check the new file, please?

Great, thanks!

comment:6 Changed 5 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [12455]) Fixed #12868 - Updated French format file. Thanks stephaner and claudep.

Refs #11637.

comment:11 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top