Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12799 closed (fixed)

missing newline causes an error on the pdf build of the django documentation

Reported by: Ivan Savov Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I wanted to have a pdf of all the django docs, and sphinx makes this easy.
however this is a little bug in topics/http/shortcuts.txt

To reproduce:

   pip -E /Users/ivan/.virtualenvs/predemo/ install sphinx
   svn co http://code.djangoproject.com/svn/django/trunk/ django-source-trunk
   cd django-source-trunk/docs/
   make latex
   ...
   cd _build/latex/
   make all-pdf
   ... 
   [145]
   ! Undefined control sequence.
   l.9688 \item[\code{mimetype}] \leavevmodeNew
                                             in version 1.0: \hyperlink{rele...

   ...
   still generates the pdf fine though...

Uber simple patch attached

Attachments (1)

pdf-output-fix.patch (414 bytes) - added by ivan.savov@… 7 years ago.
One newline character packaged with lots off diff language ;)

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by ivan.savov@…

Attachment: pdf-output-fix.patch added

One newline character packaged with lots off diff language ;)

comment:1 Changed 7 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12518]) Fixed #12799 -- Added an extra newline to help with PDF generation of documentation. Thanks to Ivan Savov for the report.

comment:3 Changed 7 years ago by Russell Keith-Magee

(In [12522]) [1.1.X] Fixed #12799 -- Added an extra newline to help with PDF generation of documentation. Thanks to Ivan Savov for the report.

Backport of r12518 from trunk.

comment:4 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top