Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12754 closed (fixed)

Backwards-incompatible change: BaseCommand.style.ERROR_OUTPUT was removed

Reported by: Jeff Balogh Owned by: nobody
Component: Core (Management commands) Version: 1.2-alpha
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This breaks django-extensions on trunk. The fix is to s/ERROR_OUTPUT/ERROR/g in the code, which remains compatible with Django 1.1.

ERROR_OUTPUT could be replaced, but a mention in the release notes would work for me.

Change History (4)

comment:1 Changed 7 years ago by Jeff Balogh

Oh, this happened in [12009] for #12112.

comment:2 Changed 7 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

ERROR_OUTPUT should probably be put on the deprecation list - it's a historical artefact that isn't used anywhere in Django's source tree - but for the benefit of backwards compatibility, it doesn't hurt to support it. I'll put in a dummy that makes ERROR_OUTPUT == ERROR for formatting purposes.

comment:3 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12376]) Fixed #12754 -- Reintroduced style.ERROR_OUTPUT as an alias for style.ERROR. Django doesn't need this itself, but it would be a backwards incompatible change to remove it. Thanks to Jeff Balogh for the report.

comment:4 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top