Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12738 closed Uncategorized (wontfix)

CSRF token name should be a configurable setting

Reported by: German M. Bravo Owned by: nobody
Component: Uncategorized Version:
Severity: Normal Keywords:
Cc: German M. Bravo Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The CSRF token name ('csrfmiddlewaretoken') should perhaps be configurable, for security reasons if not anything else...

Attachments (1)

#12738-csrf_token_url_name_configurable.diff (2.1 KB) - added by German M. Bravo 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Luke Plant

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

I don't understand why that would improve security. The security lies in the value of the token, not the name. Most CSRF attacks are going to be per-site, and a setting would be per-site. Also, if an attacker was using a more generic attack against all Django-powered sites, it would be easy to find out what the name of the token is for a specific site - one request to a page that contains a POST form, and you are done, since a simple regex will in most cases find which field 'looks like' a Django CSRF token.

Do you have an actual use case where you need this?

comment:2 Changed 7 years ago by Luke Plant

Resolution: wontfix
Status: newclosed

No response, so I presume there is no use case, so closing.

comment:3 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

comment:4 Changed 5 years ago by German M. Bravo

Cc: German M. Bravo added
Easy pickings: unset
Severity: Normal
Type: Uncategorized
UI/UX: unset

Changed 4 years ago by German M. Bravo

Note: See TracTickets for help on using tickets.
Back to Top