Code

Opened 4 years ago

Closed 4 years ago

#12726 closed (fixed)

double {{ media }} in admin templates...

Reported by: jedie Owned by: jezdez
Component: contrib.admin Version: master
Severity: Keywords: media
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I have double media files in some admin panel views. See: http://paste.pocoo.org/show/171364/

There is two times {{ media }} in the file contrib/admin/templates/admin/change_list.html since changeset 12298
One in {% block extrastyle %} and one in {% block extrahead %}

This is a bug, isn't it?

Discuss: http://groups.google.com/group/django-developers/browse_thread/thread/a74b50c5419b3251

Attachments (1)

change_list_patch.txt (799 bytes) - added by jedie 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by jedie

comment:1 Changed 4 years ago by jedie

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I also notice, that change_list.html doesn't has a {{ block.super }} in {% block extrahead %}...

I added change_list_patch.txt to change {{ medie }} with {{ block.super }}

comment:2 Changed 4 years ago by jezdez

  • Owner changed from nobody to jezdez
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 4 years ago by ebartels@…

Is there any reason not to split it up and have a call to {{media.css}} inside extrastyle block, and then {{media.js}} inside extrahead?

comment:4 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12365]) Fixed #12726 - Prevent listing media twice in admin's change list. Thanks, jedie.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.