Opened 14 years ago

Closed 14 years ago

#12718 closed (fixed)

If there's an AttributeError in a database router module, it gets swallowed up by the wrong except clause

Reported by: Jeff Balogh Owned by: nobody
Component: Database layer (models, ORM) Version: 1.2-alpha
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The attached patch tightens up the try blocks.

Attachments (1)

router-attr-error.diff​ (803 bytes ) - added by Jeff Balogh 14 years ago.
if there's an AttributeError in the router module, it gets swallowed up by the wrong except

Download all attachments as: .zip

Change History (2)

by Jeff Balogh, 14 years ago

Attachment: router-attr-error.diff​ added

if there's an AttributeError in the router module, it gets swallowed up by the wrong except

comment:1 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

(In [12336]) Fixed #12718 -- Tighten up the error handling when loading database routers. Thanks to Jeff Balogh for the report and patch.

Note: See TracTickets for help on using tickets.
Back to Top