Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12716 closed (fixed)

Validation display error in change list.

Reported by: kbrownlees Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: change list
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the admin change_list.html (http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/templates/admin/change_list.html) line 67:

67 	        <ul class="errorlist">{% for error in cl.formset.non_field_errors %}<li>{{ error }}</li>{% endfor %}</ul>

The method on a formset is actually 'non_form_errors' (not non_field_errors).
http://code.djangoproject.com/browser/django/trunk/django/forms/formsets.py line 212:

212         def non_form_errors(self):
213             """
214             Returns an ErrorList of errors that aren't associated with a particular
215             form -- i.e., from formset.clean(). Returns an empty ErrorList if there
216             are none.
217             """

Attachments (1)

12716.diff (898 bytes) - added by kbrownlees 4 years ago.
Patch for ticket 12716

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by kbrownlees

Patch for ticket 12716

comment:1 Changed 4 years ago by Alex

  • milestone set to 1.2
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [12398]) Fixed #12716 - Typo in the admin change list template. Thanks, kbrownlees.

comment:3 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.