Opened 6 years ago

Closed 10 months ago

#12713 closed New feature (fixed)

Fire 'onChange' event when adding a new option to a select box

Reported by: mishaaq Owned by: mishaaq
Component: contrib.admin Version: master
Severity: Normal Keywords: js admin onchange
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes


After adding a new option to a select box in admin (by '+' sign) django automatically selects this new option, but it doesn't fire 'onChange' event after that and I think it should. This behaviour could be helpful when there is a js code with an event listener binded to a select box.

This patch adds functionality to fire the event after the change.

Attachments (1)

fire_onchange_event_after_add_new_option.diff (1.5 KB) - added by mishaaq 6 years ago.
first patch

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by mishaaq

first patch

comment:1 Changed 6 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Marking as accepted, but really I think the solution is to rewrite this using jQuery :)

comment:2 Changed 5 years ago by mattmcc

  • Severity set to Normal
  • Type set to New feature

comment:3 Changed 5 years ago by julien

  • UI/UX set

comment:4 Changed 4 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 4 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:6 Changed 4 years ago by aaugustin

  • UI/UX set

Revert accidental batch modification.

comment:7 Changed 2 years ago by timo

  • Patch needs improvement set

comment:8 Changed 10 months ago by timgraham

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.
Back to Top