Opened 7 years ago

Closed 12 months ago

#12713 closed New feature (fixed)

Fire 'onChange' event when adding a new option to a select box

Reported by: Michał Żarłok Owned by: Michał Żarłok
Component: contrib.admin Version: master
Severity: Normal Keywords: js admin onchange
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

After adding a new option to a select box in admin (by '+' sign) django automatically selects this new option, but it doesn't fire 'onChange' event after that and I think it should. This behaviour could be helpful when there is a js code with an event listener binded to a select box.

This patch adds functionality to fire the event after the change.

Attachments (1)

fire_onchange_event_after_add_new_option.diff (1.5 KB) - added by Michał Żarłok 7 years ago.
first patch

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Michał Żarłok

first patch

comment:1 Changed 7 years ago by Alex Gaynor

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Marking as accepted, but really I think the solution is to rewrite this using jQuery :)

comment:2 Changed 5 years ago by Matt McClanahan

Severity: Normal
Type: New feature

comment:3 Changed 5 years ago by Julien Phalip

UI/UX: set

comment:4 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:6 Changed 5 years ago by Aymeric Augustin

UI/UX: set

Revert accidental batch modification.

comment:7 Changed 2 years ago by Tim Graham

Patch needs improvement: set

comment:8 Changed 12 months ago by Tim Graham

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top