Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#12707 closed (fixed)

admin actions display a warning when using list_editable (introduced in r11837)

Reported by: arne Owned by: copelco
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

"No action selected" message from r11837 displays if a changelist view contains both "admin actions" and fields marked as "list_editable".

To reproduce: just make a change in an editable field and save.

Expected result: just the message about the edited object ("%(count)s %(name)s was changed successfully.").

Actual result: two messages, one "No action selected" message and one about the edited object ("%(count)s %(name)s was changed successfully.").

Attachments (1)

12707.diff (1.9 KB) - added by copelco 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by jezdez

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by anonymous

  • Owner changed from nobody to anonymous
  • Status changed from new to assigned

comment:3 Changed 5 years ago by copelco

  • Owner changed from anonymous to copelco
  • Status changed from assigned to new

Changed 5 years ago by copelco

comment:4 Changed 5 years ago by copelco

  • Has patch set

comment:5 Changed 5 years ago by jkocherhans

Fixed by [12525]. Trac didn't pick it up for some reason.

comment:6 Changed 5 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 5 years ago by kmtracey

(In [12815]) [1.1.X] Fixed #12707. Admin action messages are no longer displayed when submitting list_editable content. Thanks, copelco.

and

Fixed #12962: Made admin delete action work again. Thanks ptone, skevy, mlavin and anyone else I've missed.

r12525 and r12813 from trunk, together to avoid the regression introduced by r12525 alone.

comment:20 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top