Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12707 closed (fixed)

admin actions display a warning when using list_editable (introduced in r11837)

Reported by: arne Owned by: Colin Copeland
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

"No action selected" message from r11837 displays if a changelist view contains both "admin actions" and fields marked as "list_editable".

To reproduce: just make a change in an editable field and save.

Expected result: just the message about the edited object ("%(count)s %(name)s was changed successfully.").

Actual result: two messages, one "No action selected" message and one about the edited object ("%(count)s %(name)s was changed successfully.").

Attachments (1)

12707.diff (1.9 KB) - added by Colin Copeland 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Jannis Leidel

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by anonymous

Owner: changed from nobody to anonymous
Status: newassigned

comment:3 Changed 7 years ago by Colin Copeland

Owner: changed from anonymous to Colin Copeland
Status: assignednew

Changed 7 years ago by Colin Copeland

Attachment: 12707.diff added

comment:4 Changed 7 years ago by Colin Copeland

Has patch: set

comment:5 Changed 7 years ago by jkocherhans

Fixed by [12525]. Trac didn't pick it up for some reason.

comment:6 Changed 7 years ago by jkocherhans

Resolution: fixed
Status: newclosed

comment:7 Changed 7 years ago by Karen Tracey

(In [12815]) [1.1.X] Fixed #12707. Admin action messages are no longer displayed when submitting list_editable content. Thanks, copelco.

and

Fixed #12962: Made admin delete action work again. Thanks ptone, skevy, mlavin and anyone else I've missed.

r12525 and r12813 from trunk, together to avoid the regression introduced by r12525 alone.

comment:20 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top