Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#12655 closed (fixed)

diffsettings command prints instead of returns

Reported by: Joe Vasquez Owned by: Joe Vasquez
Component: Core (Management commands) Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

line number 32 of source:trunk/django/core/management/commands/diffsettings.py#9961 has:

print '\n'.join(output)

this makes using this command in other (custom) commands difficult. reccommend using:

return '\n'.join(output)

Attachments (1)

return_instead_o_print.diff​ (552 bytes ) - added by Joe Vasquez 14 years ago.
replacing the "print" in diffsettings command to "return"

Download all attachments as: .zip

Change History (6)

by Joe Vasquez, 14 years ago

Attachment: return_instead_o_print.diff​ added

replacing the "print" in diffsettings command to "return"

comment:1 by Joe Vasquez, 14 years ago

Status: new → assigned

comment:2 by Russell Keith-Magee, 14 years ago

Component: Core framework → django-admin.py
Triage Stage: Unreviewed → Ready for checkin

comment:3 by Jannis Leidel, 14 years ago

Resolution: → fixed
Status: assigned → closed

(In [12463]) Fixed #12655 - diffsettings command now returns the diff instead of printing. Thanks, jobscry.

comment:4 by Jannis Leidel, 14 years ago

(In [12480]) [1.1.X] Fixed #12655 - diffsettings command now returns the diff instead of printing. Thanks, jobscry.

Backport of r12463.

comment:5 by Jacob, 13 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top