Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12655 closed (fixed)

diffsettings command prints instead of returns

Reported by: Joe Vasquez Owned by: Joe Vasquez
Component: Core (Management commands) Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

line number 32 of source:trunk/django/core/management/commands/diffsettings.py#9961 has:

print '\n'.join(output)

this makes using this command in other (custom) commands difficult. reccommend using:

return '\n'.join(output)

Attachments (1)

return_instead_o_print.diff (552 bytes) - added by Joe Vasquez 7 years ago.
replacing the "print" in diffsettings command to "return"

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Joe Vasquez

Attachment: return_instead_o_print.diff added

replacing the "print" in diffsettings command to "return"

comment:1 Changed 7 years ago by Joe Vasquez

Status: newassigned

comment:2 Changed 7 years ago by Russell Keith-Magee

Component: Core frameworkdjango-admin.py
Triage Stage: UnreviewedReady for checkin

comment:3 Changed 7 years ago by Jannis Leidel

Resolution: fixed
Status: assignedclosed

(In [12463]) Fixed #12655 - diffsettings command now returns the diff instead of printing. Thanks, jobscry.

comment:4 Changed 7 years ago by Jannis Leidel

(In [12480]) [1.1.X] Fixed #12655 - diffsettings command now returns the diff instead of printing. Thanks, jobscry.

Backport of r12463.

comment:5 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top