Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12637 closed (fixed)

GeoDjango's `inspectdb` command is broken

Reported by: jbronn Owned by: jbronn
Component: GIS Version: 1.1
Severity: Keywords: gis inspectdb introspection
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

GeoDjango overrides the inspectdb command, and was not updated when multi-db was merged into trunk (e.g., it still references SpatialBackend which no longer exists). In addition, inspectdb is almost copied verbatim -- and does not apply DRY. The command should be fixed, and should subclass the original command so that further updates will not necessitate re-copying the entire code.

Change History (3)

comment:1 Changed 7 years ago by jbronn

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Status: newassigned

comment:2 Changed 7 years ago by jbronn

Resolution: fixed
Status: assignedclosed

(In [12257]) Fixed #12637 -- GeoDjango's inspectdb command is now a subclass of Django's, and works with all spatial backends (Oracle and SpatiaLite did work before). This changeset introduces new introspection modules for all of the spatial backends and adds hooks to the original inspectdb.Command class to enable reuse.

comment:3 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top