Opened 14 years ago

Closed 14 years ago

#12605 closed (fixed)

ImproperlyConfigured improperly imported in Spatialite base wrapper

Reported by: tmcw Owned by: jbronn
Component: GIS Version: dev
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The Spatialite-specific code in spatialite/base.py necessitated the use of this exception, so imported it for the entire module, but the existing code had a local import, so in many cases, ImproperlyConfigured is treated as an undefined local variable, this producing the error message

django.core.exceptions.ImproperlyConfigured: Cannot determine the SpatiaLite version for the "mapdemo.db" database (error was "local variable 'ImproperlyConfigured' referenced before assignment").  Was the SpatiaLite initialization SQL loaded on this database?

This patch removes the redundant import, allowing the correct exception to be reported. Also the code in operations.py might want to be tighter in catching all exceptions as problems identifying the Spatialite version.

Attachments (1)

ImproperlyConfigured_bug.diff​ (611 bytes ) - added by tmcw 14 years ago.
Removes redundant import of exception class

Download all attachments as: .zip

Change History (3)

by tmcw, 14 years ago

Attachment: ImproperlyConfigured_bug.diff​ added

Removes redundant import of exception class

comment:1 by jbronn, 14 years ago

Component: Contrib apps → GIS
Owner: changed from nobody to jbronn

comment:2 by jbronn, 14 years ago

Resolution: → fixed
Status: new → closed

(In [12310]) Fixed #12605 -- Removed redundant import of ImproperlyConfigured. Thanks, tmcw.

Note: See TracTickets for help on using tickets.
Back to Top