Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#12600 closed (fixed)

Comments app template_search_list inconsistency

Reported by: hvdklauw Owned by: nobody
Component: Contrib apps Version: master
Severity: Keywords: comments
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The way templates are searched is inconsistent.
For the templatetags the comments/%s/%s/<template>.html style is used while in the views the comments/%s_%s_<template>.html is used.

This should be consistently comments/%s/%s/<template.html imho.

Attachments (1)

12600.diff (768 bytes) - added by hvdklauw 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by hvdklauw

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Seems my svn diff doesn't generate valid patches.. I'll see if I can fix it.

Changed 6 years ago by hvdklauw

comment:2 Changed 6 years ago by hvdklauw

  • Has patch set

comment:3 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [12337]) Fixed #12600 -- Added some extra search paths for comment preview templates, allowing for naming parity with other templates in comments and admin. Thanks to hvdklauw for the report.

comment:4 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top