Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12590 closed (fixed)

validators modeltest test fail under Python 2.4

Reported by: ramiro Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

This is happening since the model validation merge (r12098) * and can be seen in our buildbot: http://buildbot.djangoproject.com/builders/django-trunk%20ubuntu9.10-py2.4-sqlite/builds/147/steps/test/logs/stdio

The reason seems to be that in Python 2.4 isinstance(Exception, type) returns False and in python 2.5 it returns True,
the same applies to ValidationError.

  • But these tests weren't being run until r12156.

Attachments (1)

12590.diff (570 bytes) - added by ramiro 5 years ago.
One way to fix this issue.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by ramiro

One way to fix this issue.

comment:1 Changed 5 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

(In [12270]) Fixed #12590. Changed an expression in the validators tests to work correctly with python 2.4. Thanks, ramiro.

comment:2 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top